Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go back to previous positions behavior #5008

Merged
merged 1 commit into from
May 25, 2022

Conversation

steve-codaio
Copy link
Contributor

Revert "Fix positions iteration when starting in an inline void node (#4952)"

This reverts commit 9ce0a08.

Description
Reverts #4952 until we can figure out a fuller fix that accounts for the change in behavior in the navigation code

Checks

  • The new code matches the existing patterns and styles.
  • The tests pass with yarn test.
  • The linter passes with yarn lint. (Fix errors with yarn fix.)
  • The relevant examples still work. (Run examples with yarn start.)
  • You've added a changeset if changing functionality. (Add one with yarn changeset add.)

Revert "Fix positions iteration when starting in an inline void node (ianstormtaylor#4952)"

This reverts commit 9ce0a08.
@changeset-bot
Copy link

changeset-bot bot commented May 25, 2022

🦋 Changeset detected

Latest commit: fbeb3f8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
slate Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dylans dylans merged commit e9ea281 into ianstormtaylor:main May 25, 2022
@github-actions github-actions bot mentioned this pull request May 25, 2022
z2devil pushed a commit to z2devil/slate that referenced this pull request Dec 6, 2024
Revert "Fix positions iteration when starting in an inline void node (ianstormtaylor#4952)"

This reverts commit 9ce0a08.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants