Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't native insert in elements with white-space="pre" containing tab chars #5045

Merged
merged 2 commits into from
Jul 15, 2022

Conversation

BitPhinix
Copy link
Contributor

Description
Workaround for a obscure bug in chromium: https://bugs.chromium.org/p/chromium/issues/detail?id=1219139

Example
Behavior when adding whitespace="pre" styling to the code highlighting example and pasting tab chars:

Before:
before

After:
after

Checks

  • The new code matches the existing patterns and styles.
  • The tests pass with yarn test.
  • The linter passes with yarn lint. (Fix errors with yarn fix.)
  • The relevant examples still work. (Run examples with yarn start.)
  • You've added a changeset if changing functionality. (Add one with yarn changeset add.)

@changeset-bot
Copy link

changeset-bot bot commented Jul 11, 2022

🦋 Changeset detected

Latest commit: 89bbcfb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
slate-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@BitPhinix BitPhinix changed the title don't native insert in elements with white-space="pre" containing tab chars Don't native insert in elements with white-space="pre" containing tab chars Jul 11, 2022
@BitPhinix BitPhinix requested a review from dylans July 12, 2022 10:16
@BitPhinix
Copy link
Contributor Author

Failing test is unrelated 👀

@dylans dylans merged commit 0b2e6c7 into ianstormtaylor:main Jul 15, 2022
This was referenced Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants