fix macos accent menu when using arrow keys #5046
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes inserting accented characters using the macOS accent menu when using arrow keys
Issue
Fixes: #5038
Example
Before:

After:

Context
When holding down 'a' to type a with an accent the first 'ArrowLeft' key down is triggered with
isComposing=false
and before any event indicating that it is composing. Immediately afterward the 'normal' composition start/update events are fired and all following events haveisComposing
properly set, and because the composition start is fired before the selection change selecting the character / after the beforeinput we keep the selection obtained by manually handling the arrow keys which doesn't match the dom state and insert there because chrome doesn't fire theinsertFromComposition
.Checks
yarn test
.yarn lint
. (Fix errors withyarn fix
.)yarn start
.)yarn changeset add
.)