Customize get dirty paths #5069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e8af473 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dylans
approved these changes
Aug 4, 2022
This was referenced Aug 18, 2022
Merged
z2devil
pushed a commit
to z2devil/slate
that referenced
this pull request
Dec 6, 2024
* Move getDirtyPaths to the Editor object to allow for customization * Add changeset for getDirtyPaths customization Co-authored-by: Tom Krenzke <tom@daybreakhealth.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#4012 Previously added the ability to customize the
getDirtyPathsas one would any other editor method. In my case, this will be useful for the case where deleting a node results in two lists being adjacent to one another, in which case the I'd like the lists to be merged. Currently, the default implementation ofgetDirtyPathsonly sets the ancestors of the removed node as dirty, while I'd need to set the immediate siblings as dirty as well. Presumably there are other helpful use cases out there.From what I can tell, #4012 was approved and merged, but somewhere along the way the changes were lost. Viewing the merge commit results in a "This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository." message. And the code changes are nowhere in any of the branches I can see in Github.
All credit should go to @tomdng as they were the original contributor and implementor. I'm just trying to get the changes re-merged hoping it'll stick this time :).
Context
See #4012 for a full description of the changes and logic behind them.
Checks
yarn test.yarn lint. (Fix errors withyarn fix.)yarn start.)yarn changeset add.)