Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Shadow DOM fix for Safari 17. #5659

Conversation

MahmoudElsayad
Copy link
Contributor

@MahmoudElsayad MahmoudElsayad commented Jun 16, 2024

Description
#5648 Implements a workaround that will be applied only for Safari inside shadow root to improve the editor experience inside Safari, but it was applied to Safari < 17, and this PR enables it for Safari 17 as well, so that the editor works.

Ideally, the fix should include utilizing Selection: getComposedRanges() (I think), but that would require some work and thorough testing, so it can be scheduled for later.

Issue
Fixes: (part of) #5321

Example
193604958-b87f0802-8e8f-465b-9f50-904b9220cf2f

Checks

  • The new code matches the existing patterns and styles.
  • The tests pass with yarn test.
  • The linter passes with yarn lint. (Fix errors with yarn fix.)
  • The relevant examples still work. (Run examples with yarn start.)
  • You've added a changeset if changing functionality. (Add one with yarn changeset add.)

Copy link

changeset-bot bot commented Jun 16, 2024

🦋 Changeset detected

Latest commit: a748457

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
slate-react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dylans dylans merged commit e6254f7 into ianstormtaylor:main Jun 20, 2024
10 of 11 checks passed
@github-actions github-actions bot mentioned this pull request Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants