fix: focus loss inside Shadow DOM in Firefox. #5676
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr fixes shadow dom example in firefox browser.
Issue
Fixes: #5321
Example
Context
ReactEditor.findDocumentOrShadowRoot
returnsdocument
instead ofShadowRoot
in firefox. Because firefox doesn't supportgetSelection
onShadowRoot
.This breaks the following:
Here, for example:
slate/packages/slate-react/src/components/editable.tsx
Lines 231 to 241 in 0dc5852
So I decided to drop
root.getSelection != null
check fromReactEditor.findDocumentOrShadowRoot
and added a separate functiongetSelection
with it.Checks
yarn test
.yarn lint
. (Fix errors withyarn fix
.)yarn start
.)yarn changeset add
.)