Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Node.getIf method #5723

Merged
merged 3 commits into from
Sep 26, 2024
Merged

Conversation

RavenColEvol
Copy link
Contributor

Description
This PR is an attempt to solve below issue and provide a graceful method to get a Node.

Issue
Fixes: #4845

Example

// If node exists
const node = Node.getIf(editor, [0]); // returns respective node

// If node doesn't exist
const node = Node.getIf(editor, [0]); // return undefined rather than error

Context
I simply used the existing logic of get method and instead of throwing any error returned undefined

Checks

  • The new code matches the existing patterns and styles.
  • The tests pass with yarn test.
  • The linter passes with yarn lint. (Fix errors with yarn fix.)
  • The relevant examples still work. (Run examples with yarn start.)

Copy link

changeset-bot bot commented Sep 18, 2024

🦋 Changeset detected

Latest commit: 85452bf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
slate Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dylans dylans merged commit ee2c454 into ianstormtaylor:main Sep 26, 2024
9 of 10 checks passed
@github-actions github-actions bot mentioned this pull request Sep 26, 2024
This was referenced Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Node.getIf method
2 participants