Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: firefox test integration environment #5742

Merged
merged 4 commits into from
Oct 16, 2024
Merged

fix: firefox test integration environment #5742

merged 4 commits into from
Oct 16, 2024

Conversation

WindRunnerMax
Copy link
Contributor

Description
There's an issue with the current test:integration environment. The Firefox browser isn't working properly.

Example

https://github.com/ianstormtaylor/slate/actions/runs/11356967135/job/31589060385?pr=5737

image

After fixing this issue:

https://github.com/WindRunnerMax/slate/actions/runs/11358924149/job/31594223151

image

Checks

  • The new code matches the existing patterns and styles.
  • The tests pass with yarn test.
  • The linter passes with yarn lint. (Fix errors with yarn fix.)
  • The relevant examples still work. (Run examples with yarn start.)
  • You've added a changeset if changing functionality. (Add one with yarn changeset add.)

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 16, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: bf2fd1f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@WindRunnerMax WindRunnerMax marked this pull request as draft October 16, 2024 04:39
@WindRunnerMax
Copy link
Contributor Author

I don't understand why my action runs fine, but it fails here. Maybe I should check it again.

https://github.com/WindRunnerMax/slate/actions/runs/11358924149/job/31594223151

https://github.com/ianstormtaylor/slate/actions/runs/11358984600/job/31594373409?pr=5742

@WindRunnerMax
Copy link
Contributor Author

The root cause of the issue was a version mismatch between playwright and Ubuntu dependencies, but it's resolved now.

microsoft/playwright#30368

@WindRunnerMax WindRunnerMax marked this pull request as ready for review October 16, 2024 10:48
@WindRunnerMax WindRunnerMax mentioned this pull request Oct 16, 2024
Merged
5 tasks
@dylans
Copy link
Collaborator

dylans commented Oct 16, 2024

Thanks @WindRunnerMax!

@dylans dylans merged commit 97ffee4 into ianstormtaylor:main Oct 16, 2024
11 checks passed
dylans pushed a commit that referenced this pull request Oct 16, 2024
@WindRunnerMax @TyMick
fix: sync state on undo when editor is unfocused (#5737)
cd21bb1 
* fix: undo event when not focused

* chore: add changeset

* Add `HistoryEditor.withMerging` to docs (#5738)

* chore: just trigger test:integration

* chore: trigger test:integration

* fix: firefox test integration environment (#5742)

* fix: fix firefox test integration env

* chore: test ubuntu apt source

* chore: IMMUTABLE_INSTALLS ?

* fix: ubuntu version

* fix: undo event when not focused

* chore: add changeset

* chore: just trigger test:integration

* chore: trigger test:integration

---------

Co-authored-by: Ty Mick <5317080+TyMick@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylans dylans dylans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WindRunnerMax @dylans