Skip to content
This repository has been archived by the owner on Aug 25, 2021. It is now read-only.

Commit

Permalink
Moving to stable version of Chrome
Browse files Browse the repository at this point in the history
  • Loading branch information
Ian Walter committed Apr 13, 2020
1 parent 72e1d11 commit 1ca6972
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 5 deletions.
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ LABEL "com.github.actions.color"="green"

LABEL "repository"="http://github.com/ianwalter/puppeteer"
LABEL "homepage"="http://github.com/ianwalter/puppeteer"
LABEL "maintainer"="Ian Walter <public@iankwalter.com>"
LABEL "maintainer"="Ian Walter <pub@ianwalter.dev>"

RUN apt-get update \
# See https://crbug.com/795759
Expand All @@ -18,7 +18,7 @@ RUN apt-get update \
&& wget -q -O - https://dl-ssl.google.com/linux/linux_signing_key.pub | apt-key add - \
&& sh -c 'echo "deb [arch=amd64] http://dl.google.com/linux/chrome/deb/ stable main" >> /etc/apt/sources.list.d/google.list' \
&& apt-get update \
&& apt-get install -y google-chrome-unstable --no-install-recommends \
&& apt-get install -y google-chrome-stable --no-install-recommends \
&& rm -rf /var/lib/apt/lists/*

# When installing Puppeteer through npm, instruct it to not download Chromium.
Expand Down
11 changes: 8 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,19 +13,24 @@ Puppeteer will need to be launched with:
```js
browser.launch({ executablePath: 'google-chrome-unstable' })
```

This is done by default in [@ianwalter/bff-puppeteer][bffPuppeteerUrl].

As a [GitHub Action][actionsUrl]:

```yml
name: Main
on: push
name: CI
on:
push:
branches:
- master
pull_request:
jobs:
build:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@master
uses: actions/checkout@v2
- name: Install
uses: ianwalter/puppeteer@v2.0.0
with:
Expand Down
4 changes: 4 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@
"private": true,
"name": "puppeteer",
"version": "2.0.0",
"author": {
"name": "Ian Walter",
"url": "https://ianwalter.dev"
},
"license": "SEE LICENSE IN LICENSE",
"scripts": {
"lint": "eslint .",
Expand Down

0 comments on commit 1ca6972

Please sign in to comment.