Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the Market On Close order #14

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

flepied
Copy link

@flepied flepied commented May 3, 2024

No description provided.

@gnzsnz
Copy link
Contributor

gnzsnz commented May 6, 2024

I have quite a few order types as discribed by TWS API documentation, implemented with ib_insync. if there is an interest on this, which this PR is a sign of it. I can contribute with the order types that i have.

just let me know

@zdytch
Copy link

zdytch commented Jun 10, 2024

Type hints needed, as the library is all type hinted

@mattsta
Copy link
Contributor

mattsta commented Jun 10, 2024

I think the main feedback is there are 50+ different order types (https://www.interactivebrokers.com/en/index.php?f=4985) so the choices are:

  • do we implement and maintain and document all of them
  • or just let people use what they want and read the IBKR docs to populate the Order() fields themselves

Obvious examples are here, but the more detailed order types require so many custom fields it would be a full time job to implement and document them properly in our own API wrappers:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants