Updating ib.reqPnL method to avoid AssertionError in case of repetitive calls #56
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier, an assert statement
assert key not in self.wrapper.pnlKey2ReqId
was causing theAssertionError
whenreqPnL
is called second time for same set of inputs. This update avoids the error and returns existingPnL
class object if already subscribed.Minimum reproducible example
This creates error as follows
Even though calling
ib.reqPnL()
multiple times is not a sensible choice, this can be done accidentally by someone assumingib.reqPnL
to have same behavior asreqMktData
or other requests. These other request methods generate no error and hence thereqPnL
should also be consistent with other methods.Hence, proposing the change.