Improve maintainability

[edouardmenayde]

Fixes some problems I encountered while contributing on my last PR :

• mix format was not up-to-date, I executed it and added a check in the CI
• Fix two warnings (most of the rest is double @doc and depreciations)
• CI would not run on pull request

To be reviewed commit by commit for easier reading

[Ninigi]

I'm not sure what this was supposed to test, but I can see that it wouldn't work because String.replace/2 isn't a function...

Since this is in internal module, and the only way it is used is IdReplacer.replace_all(&Recase.to_snake/1) , I agree with removing the faulty test case. 👍

[Ninigi]

@edouardmenayde thanks for the PR, all the warnings and not canonically formatted code has been bugging me too 👍

Question before merging: are you planning to get rid of the duplicate @doc warnings in this PR as well, or is that out of scope for you? I'm just asking so I know if I should wait before merging.

[edouardmenayde]

@edouardmenayde thanks for the PR, all the warnings and not canonically formatted code has been bugging me too 👍

Question before merging: are you planning to get rid of the duplicate @doc warnings in this PR as well, or is that out of scope for you? I'm just asking so I know if I should wait before merging.

I am unsure on why it was written this way, so I didn't want to touch it.
I guessed you might be using it to generate doc outside hex doc, and it might break it.

[edouardmenayde]

Could this be merged and a new release be published ?

[Ninigi]

I'll look into a new release, but not sure it will be up today.