IBX-7448: Fixed siteaccess dropdown values #1110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamwojs
approved these changes
Jan 12, 2024
ViniTou
force-pushed
the
ibx-7448-fixed-siteaccess-dropdown
branch
from
c595edb to
31cf132
Compare
konradoboza
approved these changes
Jan 12, 2024
ViniTou
force-pushed
the
ibx-7448-fixed-siteaccess-dropdown
branch
from
31cf132 to
5a9239b
Compare
|
katarzynazawada
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v4.5maptakes parameters in other order, it was changed fromforloop during redesign so it is fine for 3.3.(for 4.6, I had created #1075 as a fix for other bug tho.)
It was working fine for most of the cases as usually siteaccess identifier is equal to siteaccess name.
QA:
This does not solve the issue with preview for
corporatesite access as this is completely different story - https://issues.ibexa.co/browse/IBX-7536Checklist:
@ibexa/engineering).