Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-7198: Updated ibexa label margin, form styling in edit and create #1220

Merged
merged 9 commits into from
Jun 20, 2024

Conversation

Gengar-i
Copy link
Contributor

@Gengar-i Gengar-i commented Mar 26, 2024

Question Answer
JIRA issue IBX-7198
Type bug
Target version v4.6
BC breaks no
Doc needed no
Related https://github.com/ibexa/activity-log/pull/89
https://github.com/ibexa/corporate-account/pull/241
https://github.com/ibexa/order-management/pull/117
https://github.com/ibexa/page-builder/pull/365
https://github.com/ibexa/payment/pull/142
https://github.com/ibexa/personalization/pull/335
https://github.com/ibexa/product-catalog/pull/1156
https://github.com/ibexa/segmentation/pull/98
https://github.com/ibexa/shipping/pull/70
https://github.com/ibexa/site-factory/pull/95
https://github.com/ibexa/dashboard/pull/127

Done:

  1. Styling header in edit form by design.
  2. Removed top margin from label (now container 'ibexa-form-field' have margin-bottom)
  3. Removed header margin. (margin: 0 in other packages is about to be removed)

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Asked for a review (ping @ibexa/engineering).

@Gengar-i Gengar-i changed the base branch from main to 4.6 March 26, 2024 09:45
@Gengar-i Gengar-i requested a review from dew326 March 27, 2024 09:00
@Gengar-i Gengar-i requested a review from lucasOsti March 28, 2024 13:07
@Gengar-i Gengar-i changed the title IBX-7198: Updated label,form styling in edit and create IBX-7198: Updated label, form styling in edit and create Mar 28, 2024
@Gengar-i Gengar-i changed the title IBX-7198: Updated label, form styling in edit and create IBX-7198: Updated ibexa label, form styling in edit and create Mar 28, 2024
@Gengar-i Gengar-i changed the title IBX-7198: Updated ibexa label, form styling in edit and create IBX-7198: Updated ibexa label margin, form styling in edit and create Mar 28, 2024
@Gengar-i Gengar-i requested a review from lucasOsti April 8, 2024 08:07
@Gengar-i Gengar-i force-pushed the ibx-7198-edit-form-styling branch from fce4873 to d59cc06 Compare April 22, 2024 11:17
@GrabowskiM GrabowskiM force-pushed the ibx-7198-edit-form-styling branch from 649d84d to 5720fbb Compare May 9, 2024 14:17
@GrabowskiM GrabowskiM requested a review from tischsoic May 9, 2024 14:24
@GrabowskiM GrabowskiM force-pushed the ibx-7198-edit-form-styling branch from d515bdc to 078a265 Compare May 27, 2024 12:14
@GrabowskiM GrabowskiM force-pushed the ibx-7198-edit-form-styling branch from 078a265 to 9d97ae7 Compare June 11, 2024 09:19
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
19.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@juskora
Copy link
Contributor

juskora commented Jun 20, 2024

QA Approved on Ibexa DXP Commerce 4.6-dev.

@dew326 dew326 merged commit 200eb6c into 4.6 Jun 20, 2024
22 of 23 checks passed
@dew326 dew326 deleted the ibx-7198-edit-form-styling branch June 20, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants