Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-7808: Added possibility to define icons for content type group #1225

Merged
merged 6 commits into from
Jun 20, 2024
Merged

IBX-7808: Added possibility to define icons for content type group #1225

merged 6 commits into from
Jun 20, 2024

Conversation

mikadamczyk
Copy link
Contributor

@mikadamczyk mikadamczyk commented Mar 28, 2024 •
edited by alongosz
Loading

🎫 Issue IBX-7808

Related PRs:

Description:

icons for all Content type groups should be added and used later in the Dashboard type to inform the user about the displayed element

For QA:

Documentation:

@mikadamczyk mikadamczyk self-assigned this Mar 28, 2024
@mikadamczyk mikadamczyk changed the base branch from main to 4.6 March 28, 2024 12:53
@mnocon mnocon added the Doc needed The changes require some documentation label Apr 2, 2024
@mikadamczyk mikadamczyk changed the title Added possibility to define icons for content type group IBX-7808: Added possibility to define icons for content type group Apr 3, 2024
@mikadamczyk mikadamczyk marked this pull request as ready for review April 4, 2024 08:37
@mikadamczyk mikadamczyk requested a review from a team April 4, 2024 08:37
konradoboza
konradoboza reviewed Apr 4, 2024
View reviewed changes
src/bundle/Resources/config/services.yaml Outdated Show resolved Hide resolved
src/bundle/Templating/Twig/ContentTypeGroupIconExtension.php Outdated Show resolved Hide resolved
src/lib/UI/Service/IconResolver.php Show resolved Hide resolved
src/lib/UI/Service/IconResolver.php Show resolved Hide resolved
src/lib/UI/Service/IconResolver.php Show resolved Hide resolved
src/lib/UI/Service/IconResolver.php Outdated Show resolved Hide resolved
@konradoboza konradoboza requested a review from a team April 4, 2024 12:15
@adamwojs
Copy link
Member

adamwojs commented Apr 5, 2024

How does the configuration looks like for content type group icons?

@mikadamczyk
Copy link
Contributor Author

How does the configuration looks like for content type group icons?

    ibexa.site_access.config.default.content_type_group.default-config:
        thumbnail: '/bundles/ibexaadminui/img/ibexa-icons.svg#file'
    ibexa.site_access.config.default.content_type_group.content:
        thumbnail: '/bundles/ibexaadminui/img/ibexa-icons.svg#content-type-content'
    ibexa.site_access.config.default.content_type_group.users:
        thumbnail: '/bundles/ibexaadminui/img/ibexa-icons.svg#user-type'
    ibexa.site_access.config.default.content_type_group.media:
        thumbnail: '/bundles/ibexaadminui/img/ibexa-icons.svg#media-type'

@adamwojs
Copy link
Member

adamwojs commented Apr 5, 2024 •
edited
Loading

Then we are missing changes in https://github.com/ibexa/admin-ui/blob/main/src/bundle/DependencyInjection/Configuration/Parser/ContentType.php to make it usable from project point of view 😉

@mikadamczyk mikadamczyk force-pushed the group-icon branch 3 times, most recently from 0eeb956 to 1ab3004 Compare April 5, 2024 12:16
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Apr 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@alongosz alongosz requested a review from a team May 8, 2024 09:20
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented May 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mikadamczyk mikadamczyk requested a review from alongosz June 12, 2024 13:58
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mikadamczyk mikadamczyk merged commit cb78c1c into 4.6 Jun 20, 2024
22 checks passed
@mikadamczyk mikadamczyk deleted the group-icon branch June 20, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katarzynazawada katarzynazawada katarzynazawada approved these changes

@alongosz alongosz alongosz approved these changes

@adamwojs adamwojs adamwojs approved these changes

@konradoboza konradoboza Awaiting requested review from konradoboza

@Nattfarinn Nattfarinn Awaiting requested review from Nattfarinn

@ViniTou ViniTou Awaiting requested review from ViniTou

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@ciastektk ciastektk

@dew326 dew326

@ViniTou ViniTou

Labels
Doc needed The changes require some documentation QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@mikadamczyk @adamwojs @alongosz @konradoboza @katarzynazawada @Nattfarinn @ciastektk @mnocon @dew326 @ViniTou