Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-8184: Implemented reusable RichText validator #1255

Merged
merged 9 commits into from
May 21, 2024
Merged

IBX-8184: Implemented reusable RichText validator #1255

merged 9 commits into from
May 21, 2024

Conversation

barw4
Copy link
Contributor

@barw4 barw4 commented Apr 25, 2024 •
edited by tischsoic
Loading

🎫 Issue IBX-8184

Related PRs:

Description:

In case an input is empty it should be handled accordingly instead of throwing an exception. Please, see the related PR as it improves validation in PB more.

Additionally reusable RichText validation was implemented.

@barw4 barw4 self-assigned this Apr 25, 2024
@barw4 barw4 added the Bug Something isn't working label Apr 25, 2024
@barw4 barw4 marked this pull request as ready for review April 25, 2024 14:53
@barw4 barw4 requested a review from a team April 25, 2024 14:54
@barw4 barw4 changed the title IBX-8184: Fixed block's form validation for empty input IBX-8184: Implemented reusable RichText validator Apr 26, 2024
@tomaszszopinski tomaszszopinski self-assigned this May 15, 2024
tomaszszopinski
tomaszszopinski approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on IbexaDXP 4.6 commerce.

@mikadamczyk mikadamczyk force-pushed the ibx-8184-fix-missing-input-form-validation branch from 6e36292 to 5e6aa8c Compare May 17, 2024 08:13
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dew326 dew326 merged commit 74c422b into 4.6 May 21, 2024
22 checks passed
@dew326 dew326 deleted the ibx-8184-fix-missing-input-form-validation branch May 21, 2024 08:19
GrabowskiM pushed a commit that referenced this pull request May 27, 2024
@barw4 @GrabowskiM
IBX-8184: Implemented reusable RichText validator (#1255)
35952a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

@dew326 dew326 dew326 approved these changes

@tischsoic tischsoic tischsoic approved these changes

@GrabowskiM GrabowskiM GrabowskiM approved these changes

@lucasOsti lucasOsti Awaiting requested review from lucasOsti

Assignees

@dew326 dew326

@barw4 barw4

@tomaszszopinski tomaszszopinski

Labels
Bug Something isn't working QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@barw4 @GrabowskiM @tischsoic @dew326 @tomaszszopinski