Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-1515: As an Editor, I want to see redesigned Create translation #126

Merged
merged 1 commit into from
Dec 22, 2021

Conversation

GrabowskiM
Copy link
Contributor

@GrabowskiM GrabowskiM commented Dec 20, 2021

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-1515
Bug fix? no
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Related PR:
https://github.com/ibexa/icons/pull/12

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@GrabowskiM GrabowskiM force-pushed the IBX-1515-translation-modal branch 2 times, most recently from 78b46cf to c0a2f78 Compare December 20, 2021 15:02
@GrabowskiM GrabowskiM force-pushed the IBX-1515-translation-modal branch from c0a2f78 to 3653522 Compare December 21, 2021 14:48
@@ -797,4 +797,7 @@
<symbol id="flag" viewBox="0 0 32 32" xmlns="http://www.w3.org/2000/svg">
<path d="M9.49899533,15.5499997 L9.5,31.2126428 C9.5,31.6276428 9.165,31.9626428 8.75,31.9626428 C8.335,31.9626428 8,31.6276428 8,31.2126428 L8,31.2126428 L7.99857646,14.3865067 C7.96686377,14.2629531 7.95,14.1334459 7.95,14 L7.95,14 L7.95,2 C7.95,1.86584426 7.96704365,1.73566929 7.99908378,1.61152223 L8,0.750000003 C8,0.335000001 8.335,0 8.75,0 C9.05923935,0 9.3240582,0.186010771 9.43894986,0.452525597 L9.5,0.45 L26.4352967,0.45 C27.2913381,0.45 27.9852967,1.14395864 27.9852967,2 C27.9852967,2.49480314 27.7490607,2.95987202 27.3494816,3.25170527 L27.3494816,3.25170527 L21.49,7.53 L27.7606388,12.814791 C28.3767073,13.3340111 28.4868396,14.2307494 28.0377326,14.8801731 L28.0377326,14.8801731 L27.9469585,14.9988893 C27.6524502,15.3483313 27.218745,15.55 26.7617495,15.55 L26.7617495,15.55 L9.49899533,15.5499997 L9.49899533,15.5499997 Z M9.49897752,1.55000114 L9.499,14.449 L26.7617495,14.45 C26.8678904,14.45 26.9697038,14.4125287 27.0499608,14.3455972 L27.1058425,14.2900001 C27.2660051,14.0999628 27.2417869,13.8160697 27.0517497,13.6559071 L27.0517497,13.6559071 L20.2461988,7.92021665 C19.9735127,7.69039798 19.9882701,7.26583552 20.2762552,7.05550515 L20.2762552,7.05550515 L26.7007052,2.3633983 C26.8167121,2.27867252 26.8852967,2.14365252 26.8852967,2 C26.8852967,1.75147186 26.6838249,1.55 26.4352967,1.55 L26.4352967,1.55 L9.49897752,1.55000114 L9.49897752,1.55000114 Z" id="Shape-Copy" fill="#131C26"></path>
</symbol>
<symbol id="interface-block" viewBox="0 0 32 32" xmlns="http://www.w3.org/2000/svg">
<path d="M15.9999999,-6.66667669e-08 C24.836556,-6.66667669e-08 31.9999999,7.16344397 31.9999999,15.9999999 C31.9999999,24.836556 24.836556,31.9999999 15.9999999,31.9999999 C7.16344397,31.9999999 -6.6666671e-08,24.836556 -6.6666671e-08,15.9999999 C-6.6666671e-08,7.16344397 7.16344397,-6.66667669e-08 15.9999999,-6.66667669e-08 Z M26.4717329,7.1437923 L7.1437923,26.4717329 C9.53319716,28.4945454 12.6241558,29.7142858 16,29.7142858 C23.5741909,29.7142858 29.7142858,23.5741909 29.7142858,16 C29.7142858,12.6241558 28.4945454,9.53319716 26.4717329,7.1437923 Z M16,2.28571423 C8.42580911,2.28571423 2.28571423,8.42580911 2.28571423,16 C2.28571423,19.3758442 3.50545457,22.4668028 5.52826713,24.8562077 L24.8562077,5.52826713 C22.4668028,3.50545457 19.3758442,2.28571423 16,2.28571423 Z" id="Combined-Shape"></path>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<path d="M15.9999999,-6.66667669e-08 C24.836556,-6.66667669e-08 31.9999999,7.16344397 31.9999999,15.9999999 C31.9999999,24.836556 24.836556,31.9999999 15.9999999,31.9999999 C7.16344397,31.9999999 -6.6666671e-08,24.836556 -6.6666671e-08,15.9999999 C-6.6666671e-08,7.16344397 7.16344397,-6.66667669e-08 15.9999999,-6.66667669e-08 Z M26.4717329,7.1437923 L7.1437923,26.4717329 C9.53319716,28.4945454 12.6241558,29.7142858 16,29.7142858 C23.5741909,29.7142858 29.7142858,23.5741909 29.7142858,16 C29.7142858,12.6241558 28.4945454,9.53319716 26.4717329,7.1437923 Z M16,2.28571423 C8.42580911,2.28571423 2.28571423,8.42580911 2.28571423,16 C2.28571423,19.3758442 3.50545457,22.4668028 5.52826713,24.8562077 L24.8562077,5.52826713 C22.4668028,3.50545457 19.3758442,2.28571423 16,2.28571423 Z" id="Combined-Shape"></path>
<path d="M15.9999999,-6.66667669e-08 C24.836556,-6.66667669e-08 31.9999999,7.16344397 31.9999999,15.9999999 C31.9999999,24.836556 24.836556,31.9999999 15.9999999,31.9999999 C7.16344397,31.9999999 -6.6666671e-08,24.836556 -6.6666671e-08,15.9999999 C-6.6666671e-08,7.16344397 7.16344397,-6.66667669e-08 15.9999999,-6.66667669e-08 Z M26.4717329,7.1437923 L7.1437923,26.4717329 C9.53319716,28.4945454 12.6241558,29.7142858 16,29.7142858 C23.5741909,29.7142858 29.7142858,23.5741909 29.7142858,16 C29.7142858,12.6241558 28.4945454,9.53319716 26.4717329,7.1437923 Z M16,2.28571423 C8.42580911,2.28571423 2.28571423,8.42580911 2.28571423,16 C2.28571423,19.3758442 3.50545457,22.4668028 5.52826713,24.8562077 L24.8562077,5.52826713 C22.4668028,3.50545457 19.3758442,2.28571423 16,2.28571423 Z"></path>

@dew326 dew326 merged commit ffc3b9a into main Dec 22, 2021
@dew326 dew326 deleted the IBX-1515-translation-modal branch December 22, 2021 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants