-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-8433: Added content tree children filtering #1290
Merged
ciastektk
merged 13 commits into
4.6
from
ibx-8433-added-content-tree-children-filtering
Aug 20, 2024
Merged
IBX-8433: Added content tree children filtering #1290
ciastektk
merged 13 commits into
4.6
from
ibx-8433-added-content-tree-children-filtering
Aug 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciastektk
changed the title
Ibx 8433 added content tree children filtering
IBX-8433: Added content tree children filtering
Jul 16, 2024
ciastektk
force-pushed
the
ibx-8433-added-content-tree-children-filtering
branch
7 times, most recently
from
July 18, 2024 09:11
79b1f47
to
606d9e8
Compare
konradoboza
reviewed
Jul 19, 2024
src/bundle/ControllerArgumentResolver/ContentTreeChildrenQueryArgumentResolver.php
Show resolved
Hide resolved
tests/bundle/ControllerArgumentResolver/ContentTreeChildrenQueryArgumentResolverTest.php
Show resolved
Hide resolved
tests/bundle/ControllerArgumentResolver/ContentTreeChildrenQueryArgumentResolverTest.php
Outdated
Show resolved
Hide resolved
tests/bundle/ControllerArgumentResolver/ContentTreeChildrenQueryArgumentResolverTest.php
Outdated
Show resolved
Hide resolved
konradoboza
approved these changes
Jul 19, 2024
ciastektk
force-pushed
the
ibx-8433-added-content-tree-children-filtering
branch
from
August 9, 2024 05:45
56166ad
to
ed285d2
Compare
adamwojs
reviewed
Aug 9, 2024
ciastektk
force-pushed
the
ibx-8433-added-content-tree-children-filtering
branch
from
August 9, 2024 08:41
ed285d2
to
560a050
Compare
adamwojs
approved these changes
Aug 17, 2024
tomaszszopinski
approved these changes
Aug 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA approved on IbexaDXP 4.6 commerce.
ciastektk
force-pushed
the
ibx-8433-added-content-tree-children-filtering
branch
from
August 20, 2024 12:12
1bdbdcf
to
b19d7a1
Compare
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
This PR adds ability to filter Content Tree children (subitems) by Criteria passed by filter query param.
For QA:
Request examples:
No filter:
GET http://127.0.0.1:8000/api/ibexa/v2/location/tree/load-subitems/1/30/0
Filter by content type identifier folder:
GET http://127.0.0.1:8000/api/ibexa/v2/location/tree/load-subitems/69/30/0?filter[ContentTypeIdentifierCriterion]=folder
Filter by content type identifier folder AND image:
GET http://127.0.0.1:8000/api/ibexa/v2/location/tree/load-subitems/69/30/0?filter[ContentTypeIdentifierCriterion][0]=folder&filter[ContentTypeIdentifierCriterion][1]=image
Filter by content type identifier image OR subtree user group:
GET http://127.0.0.1:8000/api/ibexa/v2/location/tree/load-subitems/1/10/0?filter[OR][ContentTypeIdentifierCriterion]=image&filter[OR][SubtreeCriterion]=/1/5/
Documentation: