IBX-8554: Added checks if flatpickrDate and this.flatpickrConfig.minDate exists #1305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasOsti
reviewed
Jul 26, 2024
src/bundle/Resources/public/js/scripts/core/date.time.picker.js
Outdated
Show resolved
Hide resolved
lucasOsti
requested changes
Jul 26, 2024
| @@ -17,7 +17,6 @@ class DateTimePicker { | |||
| this.inputField = this.fieldWrapper.querySelector('.ibexa-date-time-picker__input'); | |||
| this.actionsWrapper = this.fieldWrapper.querySelector('.ibexa-input-text-wrapper__actions'); | |||
| this.calendarBtn = this.actionsWrapper.querySelector('.ibexa-input-text-wrapper__action-btn--calendar'); | |||
| this.clearBtn = this.fieldWrapper.querySelector('.ibexa-input-text-wrapper__action-btn--clear'); | |||
There was a problem hiding this comment.
I think we should add a listener to this button and not remove it because in HTML this button is rendered
There was a problem hiding this comment.
This is some remnant from version 4.2.2 where we added some classes to this button. "x" Still works without it
There was a problem hiding this comment.
lucasOsti
approved these changes
Jul 29, 2024
dew326
approved these changes
Jul 29, 2024
GrabowskiM
approved these changes
Jul 29, 2024
mateuszdebinski
force-pushed
the
IBX-8554_console_errors_when_editing_eztime_field
branch
from
1ecf3c8 to
6cdbc46
Compare
|
barbaragr
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
For QA:
This PR should be tested with #1303
Documentation: