IBX-3654: Left menu and sections in edit form cleanup #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dew326
requested changes
Aug 16, 2022
|
|
||
| const { id } = sectionGroup.dataset; | ||
| const hasGroupError = !!sectionGroup.querySelector('.is-invalid'); | ||
| const correspodingMenuItem = |
There was a problem hiding this comment.
Suggested change
| const correspodingMenuItem = | |
| const correspondingMenuItem = |
| }; | ||
| const getLastSection = (sectionGroup) => { | ||
| const sections = sectionGroup.querySelectorAll('.ibexa-anchor-navigation__section'); | ||
| return sections ? [...sections].at(-1) : null; |
There was a problem hiding this comment.
Suggested change
| return sections ? [...sections].at(-1) : null; | |
| return sections ? [...sections].at(-1) : null; |
| previousFirstVisibleSection = firstVisibleSection; | ||
|
|
||
| const targetId = firstVisibleSection.dataset.id; | ||
|
|
| doc.querySelector(`.ibexa-anchor-navigation-menu .ibexa-dropdown__item[data-value="${id}"]`); | ||
| const errorIconNode = correspodingMenuItem.querySelector('.ibexa-anchor-navigation-menu__item-error'); | ||
| const dropdownWidget = doc.querySelector('.ibexa-anchor-navigation-menu .ibexa-dropdown'); | ||
| errorIconNode.classList.toggle('ibexa-anchor-navigation-menu__item-error--hidden', !hasGroupError); |
There was a problem hiding this comment.
Suggested change
| errorIconNode.classList.toggle('ibexa-anchor-navigation-menu__item-error--hidden', !hasGroupError); | |
| errorIconNode.classList.toggle('ibexa-anchor-navigation-menu__item-error--hidden', !hasGroupError); |
| @@ -1,159 +0,0 @@ | |||
| (function (global, doc, ibexa) { | |||
There was a problem hiding this comment.
This removal should be considered as BC break.
lucasOsti
approved these changes
Aug 17, 2022
dew326
approved these changes
Aug 30, 2022
tischsoic
approved these changes
Aug 31, 2022
dew326
force-pushed
the
form-menu-cleanup
branch
from
7c94b75 to
6829de6
Compare
GrabowskiM
force-pushed
the
form-menu-cleanup
branch
from
6829de6 to
6943fdd
Compare
GrabowskiM
force-pushed
the
form-menu-cleanup
branch
from
84e8079 to
86e3bdc
Compare
|
@GrabowskiM when I click on 'Content' on the left menu then all inputs disappear edit: described issue affects all available contents except (user).
|
GrabowskiM
force-pushed
the
form-menu-cleanup
branch
from
e05ec20 to
ae94c07
Compare
GrabowskiM
force-pushed
the
form-menu-cleanup
branch
from
ae94c07 to
f4e5ee4
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
This was referenced Sep 16, 2022
bogusez
approved these changes
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
$ composer fix-cs)