IBX-3716: Updated design of the selection field on the content preview screen #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
GrabowskiM
requested changes
Aug 24, 2022
|
|
||
| {% set field_value = options[field.value.selection|first]|escape %} | ||
|
|
||
| {{ block( 'simple_block_field' ) }} | ||
| <div class="ibexa-tag__content"> |
There was a problem hiding this comment.
I think there's missing ibexa-tag class somewhere here?
There was a problem hiding this comment.
this class is set by attr variable in line 186
https://github.com/ibexa/admin-ui/pull/554/files/61e5ec00e7438b1eaebcc64668ca07ed9ebbbbde#diff-03a88b29d0af2169f521b6db3be86937e4791cfa8d844d022acd2a3646927d96R186
GrabowskiM
approved these changes
Aug 25, 2022
dew326
approved these changes
Aug 25, 2022
micszo
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
$ composer fix-cs)