IBX-1455: Redesign Content Tree for OSS #59
Conversation
| @@ -167,22 +207,33 @@ export default class ContentTree extends Component { | |||
| ); | |||
| } | |||
|
|
|||
| isTreeCollapsed = () => { | |||
There was a problem hiding this comment.
do we need this in that way?
| const contentTreeContainer = doc.querySelector('.ez-content-tree-container'); | ||
| const contentTreeWrapper = doc.querySelector('.ez-content-tree-container__wrapper'); | ||
| const btn = doc.querySelector('.ibexa-btn--toggle-content-tree'); | ||
| const contentTreeContainer = doc.querySelector('.ibexa-content-tree-container'); |
There was a problem hiding this comment.
Question:
Maybe we can change the name of the class because for me wrapper and container are interchangeable terms for HTML node that groups other nodes or some content
| <li | ||
| class="c-popup-actions__item" | ||
| key={item.id} | ||
| onClick={() => { |
There was a problem hiding this comment.
Maybe just ?
| onClick={() => { | |
| onClick={() => setIsExpanded((prevState) => !prevState) } |
There was a problem hiding this comment.
we can do:
| onClick={() => { | |
| onClick={toggleExpanded} |
which for me would be the clearest solution.
| const itemsStyles = {}; | ||
| const allOptions = [...options, ...getHeaderActions()]; | ||
|
|
||
| console.log(allOptions); |
There was a problem hiding this comment.
| console.log(allOptions); |
GrabowskiM
force-pushed
the
IBX-1455-content-tree-oss
branch
from
3cc551d to
67994bc
Compare
| @@ -19,6 +20,15 @@ class ListItem extends Component { | |||
| }; | |||
| } | |||
|
|
|||
| getPrefixActions() { | |||
| const { prefixActions } = window.eZ.adminUiConfig.contentTreeWidget; | |||
There was a problem hiding this comment.
I don't think this is the best name. Maybe secondaryItemActions, beforeItemActions, preItemActions?
| @@ -167,22 +207,33 @@ export default class ContentTree extends Component { | |||
| ); | |||
| } | |||
|
|
|||
| isTreeCollapsed() { | |||
There was a problem hiding this comment.
| isTreeCollapsed() { | |
| checkIsTreeCollapsed() { |
| const prefixActionsArr = prefixActions ? [...prefixActions] : []; | ||
|
|
||
| return prefixActionsArr.sort((prefixActionA, prefixActionB) => { |
There was a problem hiding this comment.
Maybe this would be clearer?
| const prefixActionsArr = prefixActions ? [...prefixActions] : []; | |
| return prefixActionsArr.sort((prefixActionA, prefixActionB) => { | |
| if (!prefixActions) { | |
| return []; | |
| } | |
| return [...prefixActions].sort((prefixActionA, prefixActionB) => { |
| const toggleExpanded = () => { | ||
| setIsExpanded((prevState) => !prevState); | ||
| }; | ||
| const getHeaderActions = () => { |
There was a problem hiding this comment.
Is it identical to getPrefixActions from ListItemComponent?
There was a problem hiding this comment.
It takes data from different property
| <li | ||
| class="c-popup-actions__item" | ||
| key={item.id} | ||
| onClick={() => { |
There was a problem hiding this comment.
we can do:
| onClick={() => { | |
| onClick={toggleExpanded} |
which for me would be the clearest solution.
https://issues.ibexa.co/browse/IBX-1455