-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-3962: Introduced ModifyFieldDefinitionFieldsSubscriber #594
IBX-3962: Introduced ModifyFieldDefinitionFieldsSubscriber #594
Conversation
src/lib/Form/Type/Extension/EventSubscriber/DisableFieldDefinitionFieldsSubscriber.php
Outdated
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should also try to add DataTransformers
and EventListeners
back as this was one of the main arguments against this solution.
src/lib/Form/Type/Extension/EventSubscriber/ModifyFieldDefinitionFieldsSubscriber.php
Show resolved
Hide resolved
After @ibexa/php-dev discussion we decided to skip adding this to new created field. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA approved on IbexaDXP commerce 4.2
This PR introduces
ModifyFieldDefinitionFieldsSubscriber
allows to modify fields declared inFieldDefinitionType
.To use Subscriber add
Ibexa\AdminUi\Form\Type\Extension\ModifyFieldDefinitionsCollectionTypeExtension
service definition in bundle.Generic example:
Allowed options:
Example for
ibexa/seo
:Checklist:
$ composer fix-cs
)