IBX-4044: Option to use HTML in tooltips #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tischsoic
approved these changes
Oct 19, 2022
dew326
requested changes
Oct 19, 2022
src/bundle/Resources/views/themes/admin/content/edit/content_header.html.twig
Show resolved
Hide resolved
| <div | ||
| class="ibexa-edit-header__tooltip" | ||
| title="{% include '@ibexadesign/ui/edit_header_tooltip.html.twig' %}" | ||
| data-tooltip-use-html |
lucasOsti
approved these changes
Oct 20, 2022
dew326
approved these changes
Oct 20, 2022
GrabowskiM
force-pushed
the
IBX-4044-tooltips-html
branch
from
5212c40 to
81949dd
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
tomaszszopinski
approved these changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If he have documented using tooltips anywhere, it's probably worth adding that HTML is now switched of by default and to use HTML in tooltips
data-tooltip-use-htmlparameter has to be added on node with title.Also for QA - as default using HTML was switched off in whole system, there can be missed places where it should be switched on and I missed them, so probably that's thing worth checking as well. Sorry!
Checklist:
$ composer fix-cs)