Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-3667: Added icon for embed inline #627

Merged
merged 1 commit into from
Nov 2, 2022
Merged

IBX-3667: Added icon for embed inline #627

merged 1 commit into from
Nov 2, 2022

Conversation

dew326
Copy link
Contributor

@dew326 dew326 commented Oct 26, 2022

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-3667
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@dew326 dew326 added the Bug Something isn't working label Oct 26, 2022
@dew326 dew326 self-assigned this Oct 26, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@@ -269,7 +269,19 @@
<path d="M27.253 7.857l-1.36 2.183c-0.239 0.38-0.657 0.629-1.132 0.629-0.241 0-0.466-0.064-0.661-0.175l0.007 0.003-9.087-5.117c-0.408-0.233-0.678-0.666-0.678-1.161 0-0.261 0.075-0.505 0.205-0.711l-0.003 0.006 1.363-2.18c0.533-0.808 1.436-1.334 2.463-1.334 0.532 0 1.031 0.141 1.462 0.388l-0.014-0.008 6.393 3.6c0.671 0.379 1.166 1.004 1.365 1.75l0.005 0.020c0.056 0.204 0.088 0.437 0.088 0.679 0 0.53-0.154 1.024-0.421 1.439l0.006-0.011zM6.52 31.91l8.197-3.18c0.296-0.117 0.535-0.329 0.683-0.596l0.003-0.007 7.42-13.58c0.13-0.202 0.207-0.449 0.207-0.714 0-0.736-0.597-1.333-1.333-1.333-0.531 0-0.989 0.31-1.204 0.759l-0.003 0.008-7.193 13.153-6 2.333-0.297-6.213 7.257-13.25c0.13-0.202 0.207-0.449 0.207-0.714 0-0.736-0.597-1.333-1.333-1.333-0.531 0-0.989 0.31-1.204 0.759l-0.003 0.008-7.427 13.577c-0.104 0.185-0.165 0.406-0.165 0.642 0 0.020 0 0.041 0.001 0.061l-0-0.003 0.37 8.44c0.032 0.711 0.616 1.275 1.332 1.275 0.174 0 0.341-0.033 0.494-0.094l-0.009 0.003zM11.82 23.73l7.333-12.667c0.096-0.179 0.152-0.392 0.152-0.618 0-0.736-0.597-1.333-1.333-1.333-0.471 0-0.885 0.244-1.122 0.613l-0.003 0.005-7.333 12.667c-0.112 0.191-0.178 0.421-0.178 0.666 0 0.49 0.265 0.919 0.659 1.15l0.006 0.003c0.189 0.113 0.417 0.18 0.66 0.18 0.002 0 0.005 0 0.007-0h-0c0.49-0.001 0.919-0.266 1.15-0.66l0.003-0.006z"></path>
</symbol>
<symbol id="embed" viewBox="0 0 32 32" xmlns="http://www.w3.org/2000/svg">
<path d="M29 9.733L20.79.45a1.33 1.33 0 0 0-.999-.45H6.667c-.736 0-1.333.597-1.333 1.333v13a1.333 1.333 0 0 0 2.666 0V2.666h9.333v5.313c0 3.403 1.953 5.353 5.333 5.353h4v16H7.999v-1a1.333 1.333 0 0 0-2.666 0v2.333c0 .736.597 1.333 1.333 1.333h21.333c.736 0 1.333-.597 1.333-1.333v-20.05-.001c0-.339-.126-.648-.335-.883l.001.001zM20 7.98V3.583l6.263 7.083h-3.597c-1.91 0-2.667-.753-2.667-2.687zm-2.667 13.353a2.161 2.161 0 0 1-.666 1.559l-.001.001-3.727 3.72a1.334 1.334 0 0 1-1.88-1.894l2.07-2.053h-9.13a1.333 1.333 0 0 1 0-2.666h9.127l-2.067-2.053a1.333 1.333 0 0 1 .94-2.281c.367 0 .699.148.94.387l3.743 3.72c.401.397.65.948.65 1.557v.003z"></path>
<g stroke="none" stroke-width="1" fill="none" fill-rule="evenodd">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot this be a single path?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dew326 dew326 merged commit e929cd2 into 4.2 Nov 2, 2022
@dew326 dew326 deleted the embed-inline-icons branch November 2, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants