IBX-4324: fixed overflow in selected items sidebar #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gengar-i
commented
Nov 16, 2022
| @@ -2,7 +2,7 @@ | |||
| background-color: $ibexa-color-white; | |||
| position: fixed; | |||
| top: calculateRem(95px); | |||
| right: 0; | |||
| right: calculateRem(16px); | |||
There was a problem hiding this comment.
Added this 1 rem to move this sidebar inside content no idea if this was made properly or just forgotten to update
dew326
approved these changes
Nov 16, 2022
lucasOsti
approved these changes
Nov 17, 2022
GrabowskiM
approved these changes
Nov 17, 2022
tischsoic
approved these changes
Nov 22, 2022
|
@Gengar-i the displayed graphics for selected contents are still wrong. |
bogusez
suggested changes
Nov 23, 2022
…ed left inside content
Gengar-i
force-pushed
the
IBX-4324-selected-items-sidebar
branch
from
256867f to
9532c63
Compare
bogusez
suggested changes
Nov 30, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
|
Regression tests passed: ibexa/commerce#165 |
bogusez
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed overflow in selected items sidebar, added scroll, mov…
Checklist:
$ composer fix-cs)