-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-1694: Implemented Symfony Service Tag compatibility layer #12
Conversation
c6f59ae
to
2dd3594
Compare
@konradoboza #12 (review) resolved via 914caf7. Thanks! |
Yet to be discussed, but it feels like we should go either with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The convention is still a little bit blurry to me, but the general naming looks fine. Few concerns:
0a4c6a4
to
49ca5b2
Compare
v4.0
This PR adds compatibility layer for the legacy eZ Platform Symfony Service Container Tag names, defining the mapping between old names and new Ibexa names.
The solution is to find all legacy tags and add another tag with the new name and the same attributes. Legacy tag names are not removed from the definitions due to BC. Even if we ourselves remove old tags, there's no way to know if some 3rd party still relies on them.
.
) in the new tag names, but groups are related to domain/functionality rather than a package defining the tag. If there's a certain pattern associated with a tag (e.g.: visitor, handler), it is placed at the end of a name.Naming convention
ibexa.<domain>.[adapter].<specifics>.[design_pattern]
where
<specifics>
may or may not be grouped (aiming not to group) per case basis. If a group can be identified for certain items, it should be used.[]
implies optional part.Previously deprecated tags
The support for Tags that were deprecated in Ibexa 3.3 or earlier is going to be dropped. They're not included in the map. Some leftover usages will be replaced across the codebase with the new name.
ezpublish.searchEngineIndexer
ezpublish.searchEngine
ezpublish.fieldType.externalStorageHandler
ezpublish.fieldType.externalStorageHandler.gateway
ezpublish.fieldType
ezpublish_rest.field_type_processor
ezpublish.fieldType.parameterProvider
ezpublish.storageEngine.legacy.converter
ezpublish.fieldType.indexable
ez.fieldFormMapper.definition
ez.fieldFormMapper.value
TODO
Checklist:
$ composer fix-cs
).