-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-3966: Used user_content_type_identifier
configuration key inside user service
#155
Conversation
1e80a71
to
d364b2f
Compare
…e user service
d364b2f
to
9f8bedd
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if this should be a Repository setting, not SiteAccess. How would system behave if for admin you would have one identifier and for site other one? Not that we practiced this till now, but maybe it's a good moment to distinguish these settings.
Perhaps something we can discuss internally later today?
src/bundle/Core/DependencyInjection/Configuration/Parser/UserIdentifier.php
Outdated
Show resolved
Hide resolved
src/bundle/Core/DependencyInjection/Configuration/Parser/UserIdentifier.php
Outdated
Show resolved
Hide resolved
@alongosz |
8db2615
to
3c211c6
Compare
src/bundle/Core/DependencyInjection/Configuration/Parser/UserContentTypeIdentifier.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA approved on IbexaDXP 4.3 commerce.
v4.3
Not sure how we should handle BC in that case. Overriding
userClassID
was hard and as I am aware totally not documented. On the same way, just doing that without changing the adminUI parameter also did nothing in terms of using different CT than the default one.Checklist:
$ composer fix-cs
).@ibexa/engineering
).