Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-1439: Refactored SiteAccess-aware Flysystem Adapter to use proxying #189

Conversation

alongosz
Copy link
Member

@alongosz alongosz commented Jan 9, 2023

Question Answer
JIRA issue IBX-1439
Target PR #171
Type feature
Target Ibexa version v4.4
BC breaks yes

This PR replaces 1:1 copy of Flysystem's Local Adapter with the solution suggested by Flysystem's Maintainer - an Adapter which is decorating Local adapter instances which use / as filesystem root, allowing to proxy all method calls, prefixing the path with our logic beforehand. See #171 for more details about the suggested solution.

Note that given currently SiteAccess dynamic setting io.root_dir is always an absolute path, the inner adapter is going to work only if its prefix is indeed /.

TODO:

  • Check if 1st party IbexaTestKernel-dependent tests are still working

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review

@alongosz alongosz force-pushed the ibx-1439-upgrade-flysystem-use-proxy-adapter branch from 1cf25bf to 0e657bc Compare January 9, 2023 14:05
@alongosz alongosz requested review from adamwojs, mikadamczyk, Steveb-p, webhdx and a team January 10, 2023 13:40
@alongosz
Copy link
Member Author

Merging this one into #171

@alongosz alongosz merged commit ac46401 into ibx-1439-upgrade-flysystem Jan 10, 2023
@alongosz alongosz deleted the ibx-1439-upgrade-flysystem-use-proxy-adapter branch January 10, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants