IBX-5817: Exposed UserService::getUserContentTypeIdentifiers public API

[alongosz]

Question	Answer
JIRA issue	IBX-5817
Required by	https://github.com/ibexa/corporate-account/pull/194
Type	feature
Target Ibexa version	v4.6
BC breaks	no, consumer API changes

This PR exposes pre-existing private UserService::getUserContentTypeIdentifiers as public API. It could be helpful when implementing IBX-5817 to build proper query from within the package. The package should have no knowledge which configuration setting returns that information. Exposing dedicated API was quick and made more sense.

Checklist:

• Provided PR description.
• Tested the solution manually.
• Provided automated test coverage.
• Checked that target branch is set correctly.
• Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
• Asked for a review (ping @ibexa/engineering).

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[adamwojs]

It could be helpful when implementing IBX-5817 to build proper query from within the package.

Do you mean https://github.com/ibexa/corporate-account/pull/194/files#diff-09cd466416031ac3f84d4d7df59c6813967655d54790af059f5dd7fa0bc55fe8R52 ?

If yes, then there is already dedicated criterion for this use case: \Ibexa\Contracts\Core\Repository\Values\Content\Query\Criterion\IsUserBased

[adamwojs]

See #238 (comment)

[alongosz]

It could be helpful when implementing IBX-5817 to build proper query from within the package.

Do you mean https://github.com/ibexa/corporate-account/pull/194/files#diff-09cd466416031ac3f84d4d7df59c6813967655d54790af059f5dd7fa0bc55fe8R52 ?

If yes, then there is already dedicated criterion for this use case: \Ibexa\Contracts\Core\Repository\Values\Content\Query\Criterion\IsUserBased

@adamwojs IsUserBased Criterion doesn't do exactly the same thing. It performs a sub-select checking if content id exists in ezuser table. It's not the same as: "give me content items which are of the currently configured user content types". By default it leads to the same thing, but it might give different results if Integrator changes that configuration of User Content Types. The implementation in https://github.com/ibexa/corporate-account/pull/194 was based on \Ibexa\Core\Repository\UserService::loadUsersOfUserGroup which uses CriterionContentTypeIdentifier.

It's also worth to notice that

WHERE content_type.identifier IN ('user')

is more performant than

WHERE c.id IN (SELECT contentobject_id FROM ezuser)

We can of course decide that for the purpose of https://github.com/ibexa/corporate-account/pull/194 we should use IsUserBased, but given the above, I wouldn't.

This PR itself without extra context should give value. Additionally we could introduce IsUserContentType Criterion, but that requires more work.

[alongosz]

After a bit of discussion within PHP Team, we've decided not to expose content type related information further in UserService, at least for now. I'll update https://github.com/ibexa/corporate-account/pull/194 to use IsUserBased, as requested.