-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-4064: Search page #1860
IBX-4064: Search page #1860
Conversation
Should be strictly more than 10 but hit count is not known here
Avoid to lost search by surprise if reloading. Allow to share search results.
If removed, it searches in all versions.
efca554
to
5c1108b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I've checked both on Safari and Firefox that it's rendered corretly, did you have a chance to check it with Chrome?
Two (optional) remarks, we can discuss them and maybe come back to them as follow ups:
- It looks like the number of pages is capped at 100 - and with 10 items per page you can "only" get the first 1000 results.
Some queries return more than 1k results, meaning that some of them are not accessible, for example:
https://ez-systems-developer-documentation--1860.com.readthedocs.build/en/1860/search_results/?sq=Content&p=1
You cannot see what the result 1900 is, even when browsing to the last page.
What do you think about displaying 1000+
when there are more than 1k results?
- Having a full search page is great for experimentation and really tailoring the query.
When playing with this I found myself using the-
keyword a lot to remove things which I'm not looking for:
migration step
gives different results than migration step -update
.
https://ez-systems-developer-documentation--1860.com.readthedocs.build/en/1860/search_results/?sq=migration+step&p=1
I thought about including an info box somewhere in the search page informing users about this possibility - it's described in the Algolia doc: https://www.algolia.com/doc/api-reference/api-parameters/advancedSyntax/#how-to-use
It's a small feature, but useful for power users (developers). Or do you think developers already know this?
See all results
link at bottom of search dropdown menuTo wrap the search page into the doc layout, I use https://www.mkdocs.org/user-guide/writing-your-docs/#meta-data
Search page preview: https://ez-systems-developer-documentation--1860.com.readthedocs.build/en/1860/search_results/?sq=Content&p=5
Search dropdown previews:
It can be previewed anywhere on this PR build. But, notice that the “See all results” link is always wrong has the PR ID is not seen as a valid version/branch and is replaced by
master
. You can put the version back to PR ID 1860 to be on https://ez-systems-developer-documentation--1860.com.readthedocs.build/en/1860/search_results/ with the right arguments behind.The "See all results" link will bring to a page like https://ez-systems-developer-documentation--1860.com.readthedocs.build/en/1860/search_results/?sq=Content&p=1
No "See all results" link as all the results are available in the drop down suggestions.
Checklist