-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-8726: IsBookmarked
search criterion added
#2545
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
REST API examples are missing: ibexa/rest#123
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would precise "current user" earlier.
I'm not sure about the code_sample as it doesn't work as-is. Maybe it should be wrapped in command or something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My suggestions are optional. It's already good.
code_samples/ change report
|
* IsBookmarked criterion added * code moved to code_samples * PHP CS Fixes * REST API examples added * Fixes after review --------- Co-authored-by: julitafalcondusza <julitafalcondusza@users.noreply.github.com>
IsBookmarked
search criterion addedPreviews:
IsBookmarked
available for Location Search and Filtering.Checklist