Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Update 2.5 migration guide #612

Closed
wants to merge 17 commits into from
Closed

[WIP] Update 2.5 migration guide #612

wants to merge 17 commits into from

Conversation

andrerom
Copy link
Contributor

@andrerom andrerom commented May 7, 2019

Question Answer
JIRA Ticket
Versions 1.7/1.13/2.5

Update migration guide to reflect eZ Platform 2.5 and Legacy bridge 2.1 changes/improvements.

TODO:

andrerom and others added 2 commits October 21, 2019 15:26
Update migration guide to reflect eZ Platform 2.5 and Legacy bridge 1.5 (incoming) changes.
@andrerom andrerom force-pushed the 2.5_migration_update branch from 57d2069 to 64fb62f Compare October 21, 2019 13:31
@andrerom andrerom marked this pull request as ready for review October 21, 2019 13:31
@andrerom andrerom changed the title [WIP] Update migration guide Update migration guide Oct 21, 2019
Copy link
Contributor Author

@andrerom andrerom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The work here is blocked by the fact that flow migration can't be done on 1.13LTS or better yet 2.5LTS.

Making migration tools needed work on 2.5 will greatly simplify the doc here AND importantly the amount of work involved in migrating sites for partners.

docs/migrating/migrating_from_ez_publish_platform.md Outdated Show resolved Hide resolved
docs/migrating/migrating_from_ez_publish_platform.md Outdated Show resolved Hide resolved
@andrerom andrerom changed the title Update migration guide [WIP] Update migration guide Oct 21, 2019
@andrerom andrerom changed the title [WIP] Update migration guide [BLOCKED] Update migration guide Oct 21, 2019
@andrerom
Copy link
Contributor Author

andrerom commented Apr 8, 2020

Closing as impossible right now. This is beyond what Support/PS can do as they where not involved in making the field types involved here, so they don't know the details on intended behaviour.

We need the following from product team, in order to be able to provide proper migration docs for 2.5 and 3.x:

  • flow migration: support for direct migration to 2.5 and 3.x
  • landing page migration: support for direct migration to 2.5* and 3.x
  • XmlText migration: support for direct migration to 2.5 and 3.x (This is kind of done, as alongosz is taking maintenance ownership over this also for 3.0 now)

/cc @SylvainGuittard @lserwatka @bdunogier

* 2.5 Partly done by VL in doc, as doc is mentioning it's missing support for some block types that where added to Page Builder after 2.2.0.

@andrerom andrerom closed this Apr 8, 2020
@andrerom andrerom deleted the 2.5_migration_update branch April 8, 2020 07:06
@andrerom andrerom restored the 2.5_migration_update branch July 8, 2020 12:47
@andrerom andrerom reopened this Jul 8, 2020
@andrerom andrerom changed the title [BLOCKED] Update migration guide [WIP] Update migration guide Jul 8, 2020
@andrerom andrerom changed the title [WIP] Update migration guide [WIP] Update 2.5 migration guide Jul 8, 2020
docs/migrating/migrating_from_ez_publish_platform.md Outdated Show resolved Hide resolved

`MySQL: <new-ez-root>/vendor/ezsystems/ezpublish-kernel/data/update/mysql/dbupdate-5.4.0-to-6.13.0.sql`
!!! note "Change to UTF8mb4 for MySQL/MariaDB"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the only thing needed.

I think we should just instruct user to run all upgrade things mentioned at https://doc.ezplatform.com/en/latest/updating/4_update_database/, but skip LandingPage -> Page builder upgrade mentioned for 2.2

Then continue here afterwards

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I'm trying to provide a fast pass here as many steps there are not relevant when coming directly from 5.4.

We might be missing instructions for creating form container thought: https://doc.ezplatform.com/en/latest/updating/4_update_2.3/#form-builder

Can add that in 3.2.3 Add other eZ Enterprise schemas (eZ Enterprise only)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But why should you skip all of that?
You for sure need to upgrade db schema to 2.5 ( or no migration scripts will run at all). But you should for instance also create new section for "Forms" (2.4) etc. and everything else explained there in order to get a fully functional 2.5.

Copy link
Contributor Author

@andrerom andrerom Aug 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You for sure need to upgrade db schema to 2.5 ( or no migration scripts will run at all)

There is:

MySQL/MariaDB:
- `<new-ez-root>/vendor/ezsystems/ezpublish-kernel/data/update/mysql/dbupdate-5.4.0-to-6.13.0.sql`
- `<new-ez-root>/vendor/ezsystems/ezpublish-kernel/data/update/mysql/dbupdate-6.13.0-to-7.5.7.sql`

But you should for instance also create new section for "Forms" (2.4) etc. and everything else explained there in order to get a fully functional 2.5.

Yes I'm missing that one, as mentioned above, there is also a few other things we should cover.

Otherwise I think I cover everything else relevant when coming from 5.4, so to go true all of it then:

  • KO: <1.7 Changes to Solr Bundle => AFAIK invalid, there are more changes to schema from 5.4 to 2.5
    • So we should add own section here on using the new solr schema instead
  • OK: <1.13 Changes to permissions => Covered by dbupdate-5.4.0-to-6.13.0.sql AFAIK
  • OK: <1.13 Changes to form-uploaded files => Irrelevant, is about LandingPage
  • OK: <1.13 ezsearch_return_count table removal => This was covered in 5.4, could add it again if we want
  • OK: <1.13 Increased password hash length => Should be covered by dbupdate-5.4.0-to-6.13.0.sql AFAIK
  • OK: <2.2 Change from UTF8 to UTF8MB4 => Covered in the links here
  • OK: <2.2 Page builder => Not relevant, we install the table clean with all fixes in step to install EE tables
  • OK: <2.2 Migrate Landing Pages => Covered below here
  • OK: <2.3 Changes to timestamp => Covered by the NEW (PR) dbupdate-6.13.0-to-7.5.7
  • KO: <2.3 Form builder => We should add that step here or link to it, as described in comment above.
  • OK: <2.4 Workflow => Covered by instructions to install all EE tables
  • ??: <2.4 Changes to the Forms folder => Kind of assume command above to create folder uses right section, but worth checking
  • OK: <2.4 Changes to Custom tags => Irrelevant, install does not yet use RichText

Then there is 2.5 page:

  • OK: All DB steps are covered by dbupdate-6.13.0-to-7.5.7
  • OK: DoctrineSchemaBundle is already enabled as we instruct people to use clean 2.5.x as starting point here
  • OK: matrix steps is covered here
  • ??: Cache flush can be relevant, even if not for the same reasons, so we should rather add section somewhere during the steps to clear cache here using symfony cache pool command
  • OK: 2.5.3 page builder is covered in instructions here
  • OK: 2.5.6 Password expiration should be covered by dbupdate-6.13.0-to-7.5.7

@vidarl
Copy link
Contributor

vidarl commented Aug 7, 2020

My biggest concern with your proposal here is if there are new changes to 2.5 schema... Then we have to remember to add instructions here again about applying those after dbupdate-6.13.0-to-7.5.7.sql

Or, we instead have a dbupdate-6.13.0-to-7.5.0.sql and ask user to run all upgrade scripts for 2.5... ?

KO: <2.3 Form builder => We should add that step here or link to it, as described in comment above.
(...)
??: <2.4 Changes to the Forms folder => Kind of assume command above to create folder uses right section, but worth
checking

yes, so I think we either to cut&paste that doc to this migration doc, or link to it.

@andrerom
Copy link
Contributor Author

andrerom commented Aug 7, 2020

My biggest concern with your proposal here is if there are new changes to 2.5 schema... Then we have to remember to add instructions here again about applying those after dbupdate-6.13.0-to-7.5.7.sql

No, this file only goes up to 7.5.7, intention is to ask user to check if there are further changes after that in update instructions.

Or, we instead have a dbupdate-6.13.0-to-7.5.0.sql and ask user to run all upgrade scripts for 2.5... ?

This is discussed here: ezsystems/ezpublish-kernel#3048

@vidarl
Copy link
Contributor

vidarl commented Aug 7, 2020

Yeah, I saw that, and you ask yourself if it maybe should be a dbupdate-6.13.0-to-7.5.0.sql instead.

But OK, both ways works for me then

@andrerom
Copy link
Contributor Author

andrerom commented Aug 7, 2020

Same here, directly to 7.5.7 simplifies things here given we anyway update this now, however it might be confusing as it breaks former conventions. I'll probably adapt it here and there to change it.

UPDATE: The sql files have been updated to be from 6.13.0 to 7.5.0, besides the KO items in list above there now needs to be instructions about following update steps at the end here I think. Can be aligned with how 3.0 upgrade doc is doing this most likely.

@andrerom andrerom requested a review from vidarl November 4, 2020 16:25
@andrerom
Copy link
Contributor Author

andrerom commented Nov 4, 2020

@vidarl Pushed changes now, I dropped the Reactor part as I could not get it to run / install without issues.

For further suggestion, could you take over and contribute to this perhaps?

@DominikaK DominikaK closed this Jun 8, 2022
@MagdalenaZuba MagdalenaZuba deleted the 2.5_migration_update branch April 19, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants