Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-8394: [ibexa/rector] Improved default configuration #129

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

alongosz
Copy link
Member

@alongosz alongosz commented Jul 23, 2024

Caution

Requires ibexa/rector#6 to be merged first

🎫 Issue IBX-8394

Related PRs:

Description:

Changed default configuration recipe to include changes from ibexa/rector#6 - instead of hardcoding path to ./vendor/ibexa/rector/src/contracts/Sets/ibexa-50.php, an enum IbexaSetList has been introduced and used.

I've also aligned the config file with the format showcased ATM by https://getrector.com/documentation.

Copy link

Thanks for contribution! 🎉

To test the changes please execute:

composer config extra.symfony.endpoint https://api.github.com/repos/ibexa/recipes-dev/contents/index.json?ref=flex/pull-129

before executing the recipes.

@alongosz alongosz requested a review from a team July 23, 2024 11:32
@konradoboza konradoboza requested a review from a team July 23, 2024 11:49
ibexa/rector/5.0/rector.php Outdated Show resolved Hide resolved
@alongosz alongosz force-pushed the ibx-8394-ibexa-5.0-set-list-enum branch from ac79dbe to 39ff3ca Compare July 25, 2024 08:14
Copy link

@alongosz alongosz requested a review from adamwojs July 25, 2024 08:16
@alongosz alongosz merged commit a216fe8 into master Jul 25, 2024
2 checks passed
@alongosz alongosz deleted the ibx-8394-ibexa-5.0-set-list-enum branch July 25, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants