IBX-8175: OpenAPI compatible move user group endpoint #108

barw4 · 2024-06-24T16:31:33Z

🎫 Issue	IBX-8175

Related PRs:

#107

Description:

The new endpoint follows the given specification:

POST /api/ibexa/v2/user/groups/1/5/235
Content-Type: application/vnd.ibexa.api.MoveUserGroupInput+json
Accept: application/json
{
    "MoveUserGroupInput": {
        "destination": "/1/5/14"
    }
}

Documentation:

TBD

src/lib/Server/Validation/Builder/Input/Parser/MoveUserGroupInputValidatorBuilder.php

…`Content-Type` header

…function

micszo

Here also 404 is returned instead of 403 when destination does not exist. :)

ref. https://doc.ibexa.co/en/latest/api/rest_api/rest_api_reference/rest_api_reference.html#managing-users-move-user-group

sonarcloud · 2024-07-23T20:11:44Z

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

micszo

QA Approved on Ibexa Commerce 5.0.x-dev.

barw4 added Feature New feature request Ready for review labels Jun 24, 2024

barw4 self-assigned this Jun 24, 2024

github-actions bot assigned alongosz, tischsoic and Steveb-p Jun 24, 2024

barw4 requested a review from a team June 24, 2024 16:37

barw4 force-pushed the ibx-8180-swap-location-endpoint-OpenAPI branch from 3268d62 to 55e48bf Compare June 27, 2024 16:25

barw4 force-pushed the ibx-8175-move-user-group-endpoint-OpenAPI branch 2 times, most recently from dd2d5bb to 2d384c9 Compare June 28, 2024 08:47

barw4 force-pushed the ibx-8180-swap-location-endpoint-OpenAPI branch from 62e73b9 to 8abbae4 Compare June 28, 2024 14:40

barw4 force-pushed the ibx-8175-move-user-group-endpoint-OpenAPI branch from 2d384c9 to f3f8a47 Compare June 28, 2024 14:42

konradoboza approved these changes Jul 1, 2024

View reviewed changes

src/lib/Server/Validation/Builder/Input/Parser/MoveUserGroupInputValidatorBuilder.php Outdated Show resolved Hide resolved

konradoboza requested a review from a team July 1, 2024 07:20

barw4 force-pushed the ibx-8180-swap-location-endpoint-OpenAPI branch from 6969142 to 4297243 Compare July 2, 2024 22:21

webhdx approved these changes Jul 3, 2024

View reviewed changes

webhdx requested a review from a team July 3, 2024 07:35

barw4 added Ready for QA and removed Ready for review labels Jul 3, 2024

barw4 force-pushed the ibx-8180-swap-location-endpoint-OpenAPI branch from 0227bcc to 989b2f1 Compare July 16, 2024 07:46

Base automatically changed from ibx-8180-swap-location-endpoint-OpenAPI to main July 17, 2024 09:11

barw4 added 9 commits July 17, 2024 14:32

IBX-8176: Implemented routing language expression extension handling …

b141289

…`Content-Type` header

IBX-8176: CS

7de1634

IBX-8176: Added unit tests

b117cfc

IBX-8176: Enable strict_types

84b2310

IBX-8176: Enable strict_types

aa228cf

IBX-8176: Applied review remarks

5da609e

IBX-8176: Fixed type

e6e531f

IBX-8176: Refactored solution

aeb02fa

IBX-8176: Removed 'future' implementation

a54646e

barw4 added 14 commits July 17, 2024 14:32

IBX-8176: Fixed tests

b75f656

IBX-8176: Created new OpenAPI compatible location moving endpoint

e1b0f34

IBX-8176: Removed deprecation

a0c2056

IBX-8176: Refactored routing to use the is_content_type_compatible …

e2a6f9e

…function

IBX-8176: Applied review remarks

c670a6a

IBX-8176: Fixed routing definition

e9ce5db

IBX-8176: Added options_route_suffix

607b9f0

IBX-8176: Updated routing

a701171

IBX-8180: Added integration test

6dc1801

IBX-8175: OpenAPI compatible move user group endpoint

6870767

IBX-8175: CS

eb77cc2

IBX-8175: Update route definition and functional test

cca8550

IBX-8175: Updated routing

254dcb0

IBX-8175: Applied review remark

67fac58

barw4 force-pushed the ibx-8175-move-user-group-endpoint-OpenAPI branch from b53ad36 to 67fac58 Compare July 17, 2024 12:33

barw4 added 3 commits July 17, 2024 14:34

IBX-8175: Fixed routing after rebase

25a3fb9

IBX-8175: Fixed routing after rebase

141788c

IBX-8175: Add missing parser

aa67edc

micszo self-assigned this Jul 18, 2024

micszo requested changes Jul 23, 2024

View reviewed changes

IBX-8175: Added integration test

89844b9

barw4 requested a review from micszo July 23, 2024 20:12

micszo approved these changes Jul 24, 2024

View reviewed changes

micszo added QA approved and removed Ready for QA labels Jul 24, 2024

micszo removed their assignment Jul 24, 2024

Steveb-p merged commit 49748a4 into main Jul 24, 2024
8 checks passed

Steveb-p deleted the ibx-8175-move-user-group-endpoint-OpenAPI branch July 24, 2024 16:04

ezrobot pushed a commit that referenced this pull request Dec 11, 2024

IBX-9321: Bumped GH action versions (#108)

be3ca7e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

IBX-8175: OpenAPI compatible move user group endpoint #108

IBX-8175: OpenAPI compatible move user group endpoint #108

barw4 commented Jun 24, 2024 •

edited

Loading

micszo left a comment

sonarcloud bot commented Jul 23, 2024

micszo left a comment

IBX-8175: OpenAPI compatible move user group endpoint #108

IBX-8175: OpenAPI compatible move user group endpoint #108

Conversation

barw4 commented Jun 24, 2024 • edited Loading

Related PRs:

Description:

Documentation:

micszo left a comment

Choose a reason for hiding this comment

sonarcloud bot commented Jul 23, 2024

Quality Gate passed

micszo left a comment

Choose a reason for hiding this comment

barw4 commented Jun 24, 2024 •

edited

Loading