Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-1439: Dropped league/flysystem-memory dependency #41

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

alongosz
Copy link
Member

@alongosz alongosz commented Dec 19, 2022

Question Answer
JIRA issue IBX-1439
Requires ibexa/core#171
Type feature
Target Ibexa version v4.4
BC breaks not for this package

This PR updates codebase to use Flysystem v2. Bumped league/flysystem-memory to v2.
This PR drops league/flysystem-memory dependency required now by ibexa/core (ibexa/core#171).

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review

The dependency is taken from ibexa/core which contains code requiring it.
@alongosz alongosz force-pushed the ibx-1439-upgrade-flysystem branch from 817c1b3 to 24c95ca Compare December 23, 2022 14:07
@alongosz alongosz changed the title IBX-1439: Upgraded codebase to rely on Flysystem v2 IBX-1439: Dropped league/flysystem-memory dependency Dec 23, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@alongosz alongosz requested review from adamwojs, kisztof, konradoboza and a team December 23, 2022 14:09
@alongosz
Copy link
Member Author

Update: league/flysystem-memory is now ibexa/core dependency (see ibexa/core#171).

Copy link

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on IbexaDXP commerce 4.4.x.

@alongosz alongosz merged commit 23c21d0 into main Jan 13, 2023
@alongosz alongosz deleted the ibx-1439-upgrade-flysystem branch January 13, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants