Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-8726: Added support for IsBookmarked criterion #75

Merged
merged 12 commits into from
Sep 4, 2024
Merged

IBX-8726: Added support for IsBookmarked criterion #75

merged 12 commits into from
Sep 4, 2024

Conversation

ciastektk
Copy link
Contributor

@ciastektk ciastektk commented Aug 20, 2024 •
edited
Loading

@ciastektk ciastektk force-pushed the ibx-8726-added-support-for-is-bookmarked-criterion branch 2 times, most recently from 6b78934 to a5e8d63 Compare August 20, 2024 08:32
@ciastektk ciastektk requested a review from a team August 20, 2024 13:18
@ciastektk ciastektk mentioned this pull request Aug 20, 2024
Merged
@konradoboza konradoboza requested a review from a team August 21, 2024 06:16
@ciastektk ciastektk requested a review from konradoboza August 21, 2024 07:21
konradoboza
konradoboza approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@konradoboza konradoboza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But please add some reminder to drop dev dependencies on merge.

@konradoboza konradoboza requested a review from a team August 21, 2024 07:24
alongosz
alongosz reviewed Aug 26, 2024
View reviewed changes
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No unit tests for the visitor? Expected sth similar to what you did for ES.

@ciastektk
Copy link
Contributor Author

No unit tests for the visitor? Expected sth similar to what you did for ES.

@alongosz: 088a497

alongosz
alongosz approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting shape of the query. Expected sth else, but my noSQL voodoo is not on very high level. Thanks!

@alongosz alongosz requested a review from a team August 26, 2024 10:23
@bogusez bogusez self-assigned this Sep 3, 2024
This was referenced Sep 3, 2024
Closed
Closed
Closed
@ciastektk ciastektk force-pushed the ibx-8726-added-support-for-is-bookmarked-criterion branch from 088a497 to f84fd04 Compare September 4, 2024 13:41
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@alongosz alongosz merged commit 6dbe045 into 4.6 Sep 4, 2024
19 checks passed
@alongosz alongosz deleted the ibx-8726-added-support-for-is-bookmarked-criterion branch September 4, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogusez bogusez bogusez approved these changes

@konradoboza konradoboza konradoboza approved these changes

@alongosz alongosz alongosz approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

Assignees

@Steveb-p Steveb-p

@alongosz alongosz

@bogusez bogusez

Labels
Improvement QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ciastektk @Steveb-p @alongosz @konradoboza @bogusez