Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-4452: Refactored jms_translation configuration using constant #36

Merged
merged 1 commit into from
Dec 12, 2022
Merged

IBX-4452: Refactored jms_translation configuration using constant #36

merged 1 commit into from
Dec 12, 2022

Conversation

kisztof
Copy link
Contributor

@kisztof kisztof commented Dec 9, 2022

Question Answer
JIRA issue IBX-4452
Type improvement
Target Ibexa DXP version v4.4
BC breaks no
Doc needed no

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ibexa/php-dev).

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kisztof kisztof mentioned this pull request Dec 9, 2022
Merged
2 tasks
@alongosz alongosz merged commit 5138994 into main Dec 12, 2022
@alongosz alongosz deleted the ibx-4452-deprecate-translation-extractors branch December 12, 2022 10:47
@alongosz
Copy link
Member

Merged as this is self-contained and internal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konradoboza konradoboza konradoboza approved these changes

@alongosz alongosz alongosz approved these changes

@mikadamczyk mikadamczyk mikadamczyk approved these changes

Assignees

@Steveb-p Steveb-p

@alongosz alongosz

@ciastektk ciastektk

@webhdx webhdx

@konradoboza konradoboza

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kisztof @alongosz @mikadamczyk @konradoboza @Steveb-p @ciastektk @webhdx