Introduced Value Object strict getters and deprecated magic ones

ibexa · May 23, 2024 · f536693 · f536693
1 parent ca8da09
commit f536693
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 7 deletions.
diff --git a/src/lib/Strategy/DefaultThumbnailStrategy.php b/src/lib/Strategy/DefaultThumbnailStrategy.php
@@ -57,8 +57,8 @@ private function getInitials(array $fields): string
         foreach ($this->initialsFieldDefIdentifiers as $identifier) {
             /** @var \Ibexa\Contracts\Core\Repository\Values\Content\Field $field */
             foreach ($fields as $field) {
-                if ($field->fieldDefIdentifier === $identifier) {
-                    $initials .= substr((string)$field->value, 0, 1);
+                if ($field->getFieldDefinitionIdentifier() === $identifier) {
+                    $initials .= substr((string)$field->getValue(), 0, 1);
                 }
             }
         }

diff --git a/src/lib/UserSetting/UserSetting.php b/src/lib/UserSetting/UserSetting.php
@@ -11,16 +11,15 @@
 use Ibexa\Contracts\Core\Repository\Values\ValueObject;
 
 /**
- * @property string $identifier
- * @property string $name
- * @property string $description
- * @property string $value
+ * @property string $identifier @deprecated use {@see UserSetting::getIdentifier()} instead.
+ * @property string $name @deprecated use {@see UserSetting::getName()} instead.
+ * @property string $description @deprecated use {@see UserSetting::getDescription()} instead.
+ * @property string $value @deprecated use {@see UserSetting::getValue()} instead.
  */
 class UserSetting extends ValueObject
 {
     /** @var string */
     protected $identifier;
-
     /** @var string */
     protected $name;
 
@@ -29,6 +28,26 @@ class UserSetting extends ValueObject
 
     /** @var string */
     protected $value;
+
+    public function getIdentifier(): string
+    {
+        return $this->identifier;
+    }
+
+    public function getName(): string
+    {
+        return $this->name;
+    }
+
+    public function getDescription(): string
+    {
+        return $this->description;
+    }
+
+    public function getValue(): string
+    {
+        return $this->value;
+    }
 }
 
 class_alias(UserSetting::class, 'EzSystems\EzPlatformUser\UserSetting\UserSetting');