-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-1439: Dropped league/flysystem-memory dependency #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alongosz
force-pushed
the
ibx-1439-upgrade-flysystem
branch
from
December 18, 2022 23:29
748b504
to
d0ed15d
Compare
alongosz
changed the title
IBX-1439: Dropped obsolete root dependencies to Flysystem
IBX-1439: Bumped Flysystem dependencies to rely on Flysystem v2
Dec 18, 2022
alongosz
force-pushed
the
ibx-1439-upgrade-flysystem
branch
from
December 19, 2022 12:28
d0ed15d
to
72a107b
Compare
konradoboza
approved these changes
Dec 20, 2022
kisztof
approved these changes
Dec 20, 2022
ViniTou
approved these changes
Dec 20, 2022
adamwojs
approved these changes
Dec 20, 2022
alongosz
force-pushed
the
ibx-1439-upgrade-flysystem
branch
from
December 23, 2022 13:17
72a107b
to
e5545b9
Compare
alongosz
changed the title
IBX-1439: Bumped Flysystem dependencies to rely on Flysystem v2
IBX-1439: Dropped league/flysystem-memory dependency
Dec 23, 2022
The dependency is taken from ibexa/core which contains code requiring it.
alongosz
force-pushed
the
ibx-1439-upgrade-flysystem
branch
from
December 23, 2022 13:26
e5545b9
to
53a596d
Compare
Kudos, SonarCloud Quality Gate passed! |
alongosz
requested review from
adamwojs,
kisztof,
ViniTou,
konradoboza and
a team
December 23, 2022 13:26
Update: |
konradoboza
approved these changes
Dec 23, 2022
ViniTou
approved these changes
Jan 2, 2023
kisztof
approved these changes
Jan 2, 2023
kisztof
approved these changes
Jan 2, 2023
webhdx
approved these changes
Jan 5, 2023
tomaszszopinski
approved these changes
Jan 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA approved on IbexaDXP commerce 4.4.x.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v4.4
This PR bumpsThere are no direct usages ofleague/flysystem-memory
dependency to use Flysystem v2.flysystem-memory
library, howeveribexa/core
requiresrequired this as dev dependency, so we either have to do it here as well or make it production dependency inibexa/core
.UPDATE: after internal sync we've decided to move the dependency to Composer's
require
section in ibexa/core#171TODO
Checklist:
$ composer fix-cs
).