Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-7546: Wrong label in User settings - Browsing section for displayed items #74

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

GrabowskiM
Copy link
Contributor

@GrabowskiM GrabowskiM commented Feb 27, 2024

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-7546
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Checklist:

  • Implement tests
  • Coding standards ($ composer fix-cs)

Copy link

sonarcloud bot commented Feb 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@GrabowskiM GrabowskiM changed the title IBX-7546: Wrong label in User settings - Browsing section for display… IBX-7546: Wrong label in User settings - Browsing section for displayed items Feb 27, 2024
<trans-unit id="962f753514ae358c3a7c093f354f213ec553e9b3" resname="settings.group.content_authoring.name">
<source>Content authoring</source>
<target state="new">Content authoring</target>
<note>key: settings.group.content_authoring.name</note>
</trans-unit>
<trans-unit id="c9a8a7a02d6e5a8526e883fc7a6e3e35f40cf809" resname="settings.group.edit_content.description">
<source>settings.group.edit_content.description</source>
<target state="new"></target>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is suspicious but master of translation accepts so approve ;)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a common situation that the description is empty in user settings

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most suspicious for me in here is that it changed places (but yeah, I also wondered if it's ok that it's empty)

@dew326 dew326 merged commit e7fb32b into main Mar 12, 2024
16 checks passed
@dew326 dew326 deleted the IBX-7546-change-translation branch March 12, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants