forked from opentripplanner/OpenTripPlanner
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upstream merge 2023-11-08 #192
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ule data fetching since the utility method was removed. Also initial unit tests added
Co-authored-by: Thomas Gran <t2gran@gmail.com>
…siri-errors Add logging of siri errors to SiriAzureETUpdater
…e-plugin to v3.2.2
…/org.entur.gbfs-gbfs-java-model-3.x fix(deps): update dependency org.entur.gbfs:gbfs-java-model to v3.0.13
…/guava-monorepo fix(deps): update dependency com.google.guava:guava to v32.1.3-jre
…/com.google.cloud-libraries-bom-26.x fix(deps): update dependency com.google.cloud:libraries-bom to v26.26.0
Calculate CO₂ emissions of itineraries
Orca Fixes Part 2
leonardehrenfried
force-pushed
the
upstream-merge-2023-11-08
branch
from
November 8, 2023 14:24
ebcb1d6
to
de8bace
Compare
miles-grant-ibigroup
approved these changes
Nov 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one adds the improvements to the Orca fare calculation by @daniel-heppner-ibigroup: opentripplanner#5469
Perhaps interesting for IBI, Digitransit have added a CO2 emissions calculation feature to OTP. Right now it's quite tailored heavily to their needs but it's conceivable that we join forces together to develop this into something more generic.
Docs: https://docs.opentripplanner.org/en/dev-2.x/sandbox/Emissions/
Note: we have one very annoying flaky test which we are working on. You might have to restart to get the jar built.