Use the config provided by the back end server #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This all but removes the settings.yml config file in favor of requesting the config info via the fetchAppInfo server endpoint. This action is dispatched once when any component mounts. fix #367 refs ibi-group/datatools-server#229
Codecov Report
@@ Coverage Diff @@
## dev #469 +/- ##
==========================================
+ Coverage 16.14% 16.41% +0.27%
==========================================
Files 309 309
Lines 15240 15496 +256
Branches 4647 4788 +141
==========================================
+ Hits 2460 2544 +84
- Misses 10931 11052 +121
- Partials 1849 1900 +51
Continue to review full report at Codecov.
|
evansiroky
reviewed
Aug 27, 2019
evansiroky
reviewed
Aug 27, 2019
evansiroky
reviewed
Aug 27, 2019
evansiroky
suggested changes
Aug 27, 2019
evansiroky
reviewed
Aug 27, 2019
|
OK, @evansiroky. Comments have been addressed. |
evansiroky
suggested changes
Aug 30, 2019
Previously, nesting the spec yml files under the modules field of the config file was causing it to be overwritten by the information found in the appinfo response. This moves those to the specifications field to avoid that conflict.
evansiroky
reviewed
Sep 3, 2019
lib/types/index.js
Outdated
| modules: { | ||
| [name: ModuleType]: { | ||
| enabled?: boolean, | ||
| spec?: Array<any>, |
evansiroky
approved these changes
Sep 3, 2019
|
🎉 This PR is included in version 4.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
devbefore they can be merged tomaster)Description
This all but removes the settings.yml config file in favor of requesting the config info via the
fetchAppInfo server endpoint. This action is dispatched once when any component mounts.
fix #367 refs ibi-group/datatools-server#229