Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always require GTFS+ yml on config init #487

Merged
merged 1 commit into from
Sep 24, 2019
Merged

Always require GTFS+ yml on config init #487

merged 1 commit into from
Sep 24, 2019

Conversation

landonreed
Copy link
Contributor

@landonreed landonreed commented Sep 23, 2019

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JSDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing

Description

Fix #486 by always requiring GTFS+ yml.

@codecov-io
Copy link

codecov-io commented Sep 23, 2019

Codecov Report

Merging #487 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #487      +/-   ##
==========================================
+ Coverage   16.27%   16.28%   +<.01%     
==========================================
  Files         309      309              
  Lines       15308    15307       -1     
  Branches     4666     4665       -1     
==========================================
+ Hits         2492     2493       +1     
+ Misses      10954    10952       -2     
  Partials     1862     1862
Flag Coverage Δ
#unit_tests 16.28% <100%> (ø) ⬆️
Impacted Files Coverage Δ
lib/common/util/config.js 70.9% <100%> (+3.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20fe8b5...e80ba92. Read the comment docs.

@evansiroky evansiroky merged commit a2f0b12 into dev Sep 24, 2019
@evansiroky evansiroky deleted the fix-gtfs+-config branch September 24, 2019 04:12
@landonreed
Copy link
Contributor Author

🎉 This PR is included in version 4.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GTFS+ module does not work with server-provided config
3 participants