Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

为什么这儿调用两次imageFromData #78

Closed
Johnkui opened this issue Mar 25, 2016 · 2 comments
Closed

为什么这儿调用两次imageFromData #78

Johnkui opened this issue Mar 25, 2016 · 2 comments

Comments

@Johnkui
Copy link

Johnkui commented Mar 25, 2016

https://github.com/ibireme/YYWebImage/blob/master/YYWebImage/YYImageCache.m#L139-L140

140行为什么还要调用一次imageFromData呢，不能直接用newImage吗？
@ibireme
Copy link
Owner

ibireme commented Mar 25, 2016

是的，没必要，这块儿浪费了 CPU 资源，应该改一下。。
（好在现有逻辑中没有调用到这块儿）

ibireme added a commit that referenced this issue Mar 25, 2016
@ibireme
remove unnecessary code: #78
dbef382
@Johnkui
Copy link
Author

Johnkui commented Mar 25, 2016

谢谢，最近在比较YYWebImage和PINRemoteImage，从实现上和运行的性能上去做比较，后续写点东西总结下，看下来很喜欢你的coding风格和设计能力，不懂的直接来问你了哈！

@Johnkui Johnkui closed this as completed Mar 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Johnkui @ibireme