Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: OmniSciDBTable rewrites the method: drop inherited from TableExpr with behavior change #2105

Closed
anmyachev opened this issue Mar 1, 2020 · 0 comments · Fixed by #2114
Closed

BUG: OmniSciDBTable rewrites the method: drop inherited from TableExpr with behavior change #2105

anmyachev opened this issue Mar 1, 2020 · 0 comments · Fixed by #2114
Labels
bug Incorrect behavior inside of ibis

Comments

@anmyachev
Copy link
Contributor

Problem:

  • TableExpr.drop is used for drop columns, but OmniSciDBTable.drop can be only used for drop the table from database.

Workaround:

  • table[table].drop(fields) where type(table) = <class 'ibis.omniscidb.client.OmniSciDBTable'>.

Proposed solutions:

  • rename OmniSciDBTable.drop -> OmniSciDBTable.drop_table
  • remove drop method from OmnisciDBTable class and using OmniSciDBClient.drop_table instead (I prefer this option)
@anmyachev anmyachev mentioned this issue Mar 3, 2020
Merged
@jreback jreback added bug Incorrect behavior inside of ibis omnisci labels Mar 14, 2020
@jreback jreback added this to the Next Bugfix Release milestone Mar 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Incorrect behavior inside of ibis
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BUG: remove drop method anmyachev/ibis
2 participants
@jreback @anmyachev