Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: remove drop method #2114

Merged
merged 2 commits into from
Mar 14, 2020
Merged

BUG: remove drop method #2114

merged 2 commits into from
Mar 14, 2020

Conversation

anmyachev
Copy link
Contributor

closes #2105

xmnlab
xmnlab reviewed Mar 3, 2020
View reviewed changes
Copy link
Contributor

@xmnlab xmnlab left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anmyachev I think it makes sense. I think any DDL probably should be used with just Client.

I will check if it needs any change in documentation and/or tests.

@jreback when you have time could you give a second review pls? thanks

@xmnlab xmnlab added bug Incorrect behavior inside of ibis ddl Issues related to creating or altering data definitions omnisci labels Mar 6, 2020
@jreback
Copy link
Contributor

jreback commented Mar 12, 2020

so this didn't change any tests?

@anmyachev
Copy link
Contributor Author

It doesn’t change, because everywhere in tests the conn.drop_table is used

@jreback jreback added this to the Next Feature Release milestone Mar 14, 2020
@jreback jreback merged commit 51a21f9 into ibis-project:master Mar 14, 2020
@jreback
Copy link
Contributor

jreback commented Mar 14, 2020

thanks, should actually have a release note as this is a public change; if you can push this in another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmnlab xmnlab xmnlab left review comments

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
bug Incorrect behavior inside of ibis ddl Issues related to creating or altering data definitions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: OmniSciDBTable rewrites the method: drop inherited from TableExpr with behavior change
3 participants
@anmyachev @jreback @xmnlab