docs(examples): add asof_join weather example
#10507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gforsyth
reviewed
Nov 19, 2024
There was a problem hiding this comment.
Thanks for putting this together @IndexSeek ! One small nit to avoid pain in the future.
ibis/expr/types/relations.py
Outdated
Comment on lines
3286
to
3288
| >>> sensors.asof_join(events, on="event_time", predicates="site", tolerance=tolerance).drop( | ||
| ... "event_time_right" | ||
| ... ) |
There was a problem hiding this comment.
Maybe we can order here by event_time? Or by humidity, I guess -- but we'll want a consistent ordering so the doctests don't fail randomly due to row order
There was a problem hiding this comment.
Thank you for the reminder, good catch! This ordering not only helps ensure the doctests pass but I think it makes the asof_join result a bit clearer to the user seeing the gaps where they are.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Sets up a scenario for an example of using
asof_joinusing weather data, including sensor data collection and various weather events.