chore(polars): add database arg, for consistency
#10555
Merged
+13
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
polars
|
That docs error should've raised in #9840 -- I'll fix that up in a separate PR |
deepyaman
force-pushed
the
chore/polars/add-database-arg
branch
from
aca287f to
de5b5b6
Compare
Sounds good! Looks like everything else is passing, so I marked it ready for review. |
deepyaman
force-pushed
the
chore/polars/add-database-arg
branch
from
de5b5b6 to
a88ac35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Accept
databasein thePolarsBackend.table(), but error if it's notNone.Also, do a bit of standardization.
Issues closed