fix(typing): update common typing to skip non-existent attributes #10666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skipping a property if the attribute is not available
|
ACTION NEEDED Ibis follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
Testing the typing module in ibis.common
millsks
changed the title
cpcloud
requested changes
Jan 12, 2025
|
|
||
| def test_get_type_hints_with_attribute_error(): | ||
| hints = get_type_hints(TestClass, include_properties=True) | ||
| assert hints == {"a": int, "b": str} |
There was a problem hiding this comment.
This is failing because the attribute error isn't raised until accessing an instance property, but the function that extracts these properties operates on classes, not instances.
|
I don't think we have enough information about the original issue to warrant a solution yet. Let's discuss on the original issue if you're still interested in fixing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update common typing to skip attributes when attempting to load properties for various data type objects and do not exist.
Resolves #10665